Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added modules prepend to node.js tech #80

Merged
merged 2 commits into from
Oct 20, 2014
Merged

added modules prepend to node.js tech #80

merged 2 commits into from
Oct 20, 2014

Conversation

dab
Copy link

@dab dab commented Oct 14, 2014

No description provided.

@@ -48,7 +48,8 @@
"bemtree.js" : "require('enb-bemxjst/techs/bemtree-old')",
"core-bemhtml" : "require('enb-bemxjst/techs/bemhtml-old')",
"bh" : "require('enb-bh/techs/bh-server')",
"node.js" : "require('enb-diverse-js/techs/node-js')",
"pre-node.js" : "require('enb-diverse-js/techs/node-js'), { target: '?.pre.node.js' }",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

@tadatuta tadatuta closed this Oct 14, 2014
@tadatuta tadatuta reopened this Oct 14, 2014
@tadatuta
Copy link
Contributor

@dab yeah, sounds reasonable, reopened

@dab
Copy link
Author

dab commented Oct 14, 2014

up

@tadatuta
Copy link
Contributor

@dab can you please update tests as well?

@dab
Copy link
Author

dab commented Oct 14, 2014

ok! will ping after.

@dab
Copy link
Author

dab commented Oct 14, 2014

@tadatuta up

@eGavr
Copy link
Contributor

eGavr commented Oct 14, 2014

I can fix tests myself.

They failed, because PR changes the algorithm of config generation.

eGavr added a commit that referenced this pull request Oct 20, 2014
added modules prepend to node.js tech
@eGavr eGavr merged commit 6dd01ed into master Oct 20, 2014
@eGavr eGavr deleted the issue-79 branch October 20, 2014 09:49
@eGavr
Copy link
Contributor

eGavr commented Oct 20, 2014

closes #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants