i-bem: use resetApplyNext before entering content
#653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip all `applyNext()` flags before entering the `content` to support recursive blocks with `applyNext()` (see test).
|
@indutny What abilities it provides? Could not get it from the bem/bem-core#899 thread =( |
| @@ -472,6 +472,7 @@ default: { | |||
| var content = apply(this._mode = 'content'); | |||
| if(content || content === 0) { | |||
| var isBEM = this.block || this.elem; | |||
| resetApplyNext(); | |||
There was a problem hiding this comment.
Do we need to declare noop-fallback resetApplyNext() as in bem/bem-core#899?
There was a problem hiding this comment.
Hm... after some consideration, I'm not sure how this could be done. This thing is declared in completely different way in bem-core. It is a keyword in old xjst.
|
@arikon it fixes the test ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip all
applyNext()flags before entering thecontentto supportrecursive blocks with
applyNext()(see test).Not sure if the branch is correct.
See: bem/bem-core#899 for cross-reference.