Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-group: Wrong styling for dropdown #1741

Closed
tadatuta opened this issue Jan 16, 2016 · 5 comments
Closed

control-group: Wrong styling for dropdown #1741

tadatuta opened this issue Jan 16, 2016 · 5 comments
Assignees
@gela-d
Labels
bug CSS v3

Comments

@tadatuta
Copy link
Member

Since dropdown is two DOM nodes now (trigger + popup) last-child selector works wrong:
http://i.imgur.com/DAMqGDb.png
@tadatuta tadatuta mentioned this issue Jan 16, 2016
Closed
@narqo
Copy link
Member

narqo commented Jan 17, 2016

Looks like this is a degradation after #1392.

@veged
Copy link
Member

veged commented Feb 3, 2016

@tadatuta can it be fixed in CSS or it's better to rollback #1392

@veged veged added the ready label Feb 3, 2016
@tadatuta
Copy link
Member Author

tadatuta commented Feb 3, 2016

it can with several selectors with :last-of-type

@veged
Copy link
Member

veged commented Feb 9, 2016

ok, so keep it [ready]

@narqo
Copy link
Member

narqo commented Mar 9, 2016

@tadatuta @gela-d any estimates here?

@vithar vithar mentioned this issue Apr 30, 2016
Merged
tadatuta pushed a commit that referenced this issue May 10, 2016
@vithar
control-group: Wrong styling for dropdown #1741
e50ed3c
tadatuta added a commit that referenced this issue May 10, 2016
@tadatuta
Merge pull request #1836 from /issues/1741@v3
3482cb2 
control-group: Wrong styling for dropdown #1741
@tadatuta tadatuta added the v3 label May 10, 2016
@tadatuta tadatuta removed the ready label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gela-d gela-d

Labels
bug CSS v3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@veged @narqo @tadatuta @gela-d