Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove highlight control when tap on touch devices #1390 #1391

Merged
merged 1 commit into from
Mar 13, 2015
Merged

Conversation

hcodes
Copy link
Contributor

@hcodes hcodes commented Mar 6, 2015

No description provided.

@hcodes
Copy link
Contributor Author

hcodes commented Mar 6, 2015

/cc @mishanga @sipayRT


&.link_disabled
{
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find any highlight on tap for disabled link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry, already found

@sipayRT
Copy link
Contributor

sipayRT commented Mar 10, 2015

maybe it will be better to move these changes to the touch level?

@tadatuta
Copy link
Member

maybe it will be better to move these changes to the touch level?

we declare that desktop sites should work fine on touch devices

@sipayRT
Copy link
Contributor

sipayRT commented Mar 10, 2015

ok, tnx.
@hcodes works fine for me

@narqo narqo added this to the v2.1 milestone Mar 13, 2015
narqo pushed a commit that referenced this pull request Mar 13, 2015
 Remove highlight control when tap on touch devices #1390
@narqo narqo merged commit 8afb797 into v2 Mar 13, 2015
@narqo narqo deleted the issues/1390@v2 branch March 13, 2015 10:15
@narqo narqo removed this from the v2.1 milestone Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants