Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropdown: improve JAWS readability #1636

Merged
merged 2 commits into from
Sep 2, 2015
Merged

Conversation

sipayRT
Copy link
Contributor

@sipayRT sipayRT commented Aug 13, 2015

Closes #1501

@sipayRT sipayRT added the ready label Aug 13, 2015
@sipayRT
Copy link
Contributor Author

sipayRT commented Aug 13, 2015

@aristov need your opinion here

@tadatuta tadatuta mentioned this pull request Aug 14, 2015
20 tasks
@aristov
Copy link
Contributor

aristov commented Aug 14, 2015

#1393 was merged. Rebase, please.

@sipayRT sipayRT force-pushed the issues/1206-common@v2 branch from 094b290 to f77d039 Compare August 17, 2015 08:57
@sipayRT sipayRT force-pushed the issues/1501@v2 branch 3 times, most recently from 068af87 to 7ab6fb4 Compare August 17, 2015 13:55
@sipayRT sipayRT force-pushed the issues/1206-common@v2 branch from f77d039 to d7e0201 Compare August 17, 2015 14:15
@sipayRT
Copy link
Contributor Author

sipayRT commented Aug 17, 2015

@aristov gemini-tests fails because of focus changing. I'll fix screenshots after your review

},

'true' : function() {
this._popup.domElem.attr('tabindex', 0).focus();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution contradicts our a11y manual: https://nda.ya.ru/3Quhd7

Focus should be on button after dropdown expansion.

Let's solve focus maintaining problems later and separately from readability (#1026).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aristov
Copy link
Contributor

aristov commented Sep 2, 2015

LGTM

@sipayRT sipayRT changed the title [WIP] dropdown: improve JAWS readability dropdown: improve JAWS readability Sep 2, 2015
sipayRT added a commit that referenced this pull request Sep 2, 2015
dropdown: improve JAWS readability
@sipayRT sipayRT merged commit 4992490 into issues/1206-common@v2 Sep 2, 2015
@sipayRT sipayRT removed the ready label Sep 2, 2015
@sipayRT sipayRT deleted the issues/1501@v2 branch September 2, 2015 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants