Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split responsibility i-bem, i-bem__dom #413

Closed
dfilatov opened this issue Feb 22, 2014 · 3 comments
Closed

Split responsibility i-bem, i-bem__dom #413

dfilatov opened this issue Feb 22, 2014 · 3 comments
Labels
v4
Milestone
4.0

Comments

@dfilatov
Copy link
Member

I suggest to split current i-bem and i-bem__dom modules into following ones with clear responsibilities (instead of current mess with classes, declaration, constants and bulk operations):

  • (i-)?bem -- facade for operations with bem-blocks. It contains decl and create methods.
  • (i-)?bem__block -- base bem-block. It shouldn't be used directly.
  • (i-)?bem-dom -- facade for bemdom-blocks. It contains decl, init, destruct, update, before, after, etc. and some fields like scope, win, doc).
  • (i-)?bem-dom__block -- base bemdom-block. It's inherited from bem__block and shouldn't be used directly as well.
@dfilatov
Copy link
Member Author

dfilatov commented Mar 4, 2014

@veged @narqo
Could you provide your opinions about that?

@veged
Copy link
Member

veged commented Mar 4, 2014

I pfrefer discuss offline about such complex things ;-)

@dfilatov dfilatov added the v3 label Apr 17, 2014
@veged veged added this to the 3.0 milestone Apr 24, 2014
@dfilatov dfilatov removed the question label Jul 2, 2014
dfilatov added a commit that referenced this issue Jul 2, 2014
@dfilatov
Split responsibility i-bem, i-bem__dom (close #413)
dfbbeb8
dfilatov added a commit that referenced this issue Jul 2, 2014
@dfilatov
Merge pull request #580 from /issues/413@v3
af6688b 
Split responsibility i-bem, i-bem__dom (close #413), i-bem__collection, i-bem-dom__collection: remove (close #575)
@qfox
Copy link
Member

qfox commented Jan 30, 2015

Seems like it should be closed since #580 was merged to v3

@qfox qfox closed this as completed Jan 30, 2015
@dfilatov dfilatov mentioned this issue Apr 19, 2016
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@veged @dfilatov @qfox