Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page.bemhtml: x-ua-compatible is broken #794

Closed
Murdalay opened this issue Jan 15, 2015 · 3 comments
Closed

page.bemhtml: x-ua-compatible is broken #794

Murdalay opened this issue Jan 15, 2015 · 3 comments
Assignees
@tadatuta
Labels
bug v2 v4

Comments

@Murdalay
Copy link
Contributor

New is created instead of updating the existed one when changing x-ua-compatible field to arbitrary string.
head: { elem: 'head', 'x-ua-compatible': false } just do nothing.

Is that a bug or something wrong with BEMJSON examples?
@Murdalay Murdalay changed the title page on desktop level. New <meta> is created instead of updating the existed one when changing x-ua-compatible field. page block on desktop level. Jan 15, 2015
@tadatuta tadatuta changed the title page block on desktop level. page.bemhtml: x-ua-compatible is broken Jan 15, 2015
@tadatuta tadatuta mentioned this issue Jan 15, 2015
Merged
@veged veged added the v2 label Jan 29, 2015
narqo pushed a commit that referenced this issue Mar 16, 2015
Merge pull request #795 from /issues/794@v2
6f18962 
page: Fix x-ua-compatible support
@narqo narqo removed the question label Mar 16, 2015
@narqo
Copy link
Member

narqo commented Mar 16, 2015

@tadatuta shouldn't it be fixed in v3 as well?

@tadatuta tadatuta added the v4 label Mar 16, 2015
@tadatuta tadatuta reopened this Mar 16, 2015
@tadatuta
Copy link
Member

It should but I'm not sure it's a good idea to do so until #841
Otherwise we'll get quite a lot of conflicts.

@qfox
Copy link
Member

qfox commented Mar 18, 2015

@tadatuta Please, take a look and gimme further instructions.

@deeonis deeonis added ready and removed ready labels May 19, 2015
@tadatuta tadatuta mentioned this issue Jun 13, 2015
Merged
tadatuta added a commit that referenced this issue Jun 13, 2015
@tadatuta
Merge pull request #1057 from /issues/794@v3
78b3f3c 
page: Fix x-ua-compatible support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadatuta tadatuta

Labels
bug v2 v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@veged @narqo @tadatuta @qfox @Murdalay @deeonis