Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring: Move to uri__querystring #967

Closed
veged opened this issue Mar 30, 2015 · 2 comments
Closed

querystring: Move to uri__querystring #967

veged opened this issue Mar 30, 2015 · 2 comments
Assignees
@veged
Labels
v4
Milestone
4.0

Comments

@veged
Copy link
Member

veged commented Mar 30, 2015

It's more natural hierarchy to have uri block and uri__querystring element.
@veged veged added the v4 label Mar 30, 2015
@veged veged added this to the 3.0 milestone Mar 30, 2015
@tadatuta
Copy link
Member

@veged let's also think about getting rid of it at all in honour of https://github.com/bem/bem-history/tree/v2/common.blocks/uri as otherwise we'll get a conflict.

@veged veged added the question label Apr 29, 2015
@dfilatov dfilatov added ready and removed question labels Dec 8, 2015
@dfilatov
Copy link
Member

dfilatov commented Dec 8, 2015

@tadatuta Since this is a major change in v3 so bem-history is supposed to consider that while migrating.

@veged veged mentioned this issue Apr 11, 2016
Closed
@veged veged self-assigned this Apr 11, 2016
@veged veged mentioned this issue Apr 11, 2016
Merged
veged added a commit that referenced this issue Apr 12, 2016
@veged
querystring: Move to uri__querystring (closes #967)
0449437
veged added a commit that referenced this issue Apr 12, 2016
@veged
Merge pull request #1307 from /issues/967@v4
95c1692 
querystring: Move to uri__querystring
@veged veged closed this as completed Apr 13, 2016
@veged veged removed the in progress label Apr 13, 2016
@veged veged mentioned this issue May 27, 2016
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veged veged

Labels
v4
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
4 participants
@veged @dfilatov @tadatuta @tavriaforever