Support `mod(m)` and `elemMod(em)` without second argument #346

miripiruni · 2016-09-12T14:54:46Z

Fixed #274

Am I do it right?

coveralls · 2016-09-12T15:01:39Z

Coverage increased (+0.005%) to 97.038% when pulling 7a48f32 on issue-274__mods-wildcard into 49a3e10 on master.

veged · 2016-09-13T09:52:30Z

docs/ru/5-templates-syntax.md

+block('a').mod('size', '*').mix()('sized');
+```
+Оба шаблона будут применены к узлам BEMJSON-а, у которых блок равен 'a' и
+присутствует модификатор 'size' (со значением отличным от `undefined`).


не только undefined это отсутствие модификатора, а ещё и ''

@veged

null не берем в расчет?

что скажешь про явное указание значения *? Его хотим обрабатывать? Я бы оставил его.

Мы обычно пишем false везде.

veged · 2016-09-13T10:02:21Z

looks ok

coveralls · 2016-09-14T11:56:19Z

Coverage increased (+0.005%) to 96.962% when pulling 34a6223 on issue-274__mods-wildcard into b2f14b7 on master.

tadatuta · 2016-09-14T12:55:01Z

docs/en/5-templates-syntax.md

+{ block: 'a', mods: { size: '', theme: 'dark' } }
+```
+
+But templates will not applied for entities:


will not applied -> will not be applied

@tadatuta OK

miripiruni · 2016-09-14T14:47:31Z

@tadatuta thank you!

Updated.

coveralls · 2016-09-14T14:51:34Z

Coverage increased (+0.005%) to 96.962% when pulling 288964c on issue-274__mods-wildcard into b2f14b7 on master.

qfox

Looks good at all. ;-)

qfox · 2016-09-14T22:32:02Z

docs/en/5-templates-syntax.md

@@ -123,6 +123,29 @@ The template are applied. Result:
 <small class="item item_size_1"></small>
 ```

+If second argument of `mod()` was omited or equal is to '*' then templates with any


equal is to → equal to

qfox · 2016-09-14T22:32:39Z

docs/en/5-templates-syntax.md

@@ -123,6 +123,29 @@ The template are applied. Result:
 <small class="item item_size_1"></small>
 ```

+If second argument of `mod()` was omited or equal is to '*' then templates with any
+value of modifier will be applied.


any value → any non-empty value ?

qfox · 2016-09-14T22:34:20Z

docs/en/5-templates-syntax.md

+block('a').mod('size').tag()('span');
+block('a').mod('size', '*').mix()('sized');
+```
+Both templates will be applied to BEMJSON entities if block equals to 'a' and


"BEMJSON entities" is a strange thing. Do we declare it somewhere?
BEM entity is absolutely another thing.

qfox · 2016-09-14T22:35:27Z

docs/en/5-templates-syntax.md

+block('a').mod('size', '*').mix()('sized');
+```
+Both templates will be applied to BEMJSON entities if block equals to 'a' and
+'size' modifier exists (with value not `undefined` or `''`).


equal neither to ... nor to ...

qfox · 2016-09-14T22:38:40Z

docs/en/5-templates-syntax.md

+{ block: 'a', mods: { size: '', theme: 'dark' } }
+```
+
+But templates will not be applied for entities:


Guess we should not use entities here. BEMJSON nodes or Nodes?

be applied for entities: → be applied to:?

qfox · 2016-09-14T22:44:16Z

docs/ru/5-templates-syntax.md

@@ -152,6 +176,10 @@ block('page').elem('content').elemMod('type', 'index').mix()({ block: 'mixed' })

 `elemModVal` проверяются на соответствие после приведения к строке. Это поведение аналогично поведению проверки `modVal`.

+Второй аргумент `elemMods()` также может отстуствовать или быть равен '*', в


'*' в бэктики?

qfox · 2016-09-14T22:44:41Z

docs/ru/5-templates-syntax.md

@@ -152,6 +176,10 @@ block('page').elem('content').elemMod('type', 'index').mix()({ block: 'mixed' })

 `elemModVal` проверяются на соответствие после приведения к строке. Это поведение аналогично поведению проверки `modVal`.

+Второй аргумент `elemMods()` также может отстуствовать или быть равен '*', в
+этом случае поведение аналогичное режиму `mods()` — шаблоны будут применены к
+узлам с модификатором любого значения.


почему здесь «узлам», а в англ. версии BEMJSON entities или entities? узлы лучше, и не противоречат key-concepts из методологии

qfox · 2016-09-14T22:45:29Z

docs/ru/5-templates-syntax.md

@@ -117,12 +117,36 @@ block('item')
 <small class="item item_size_1"></small>
 ```

+Если второй аргумент `mod()` отсутствует либо равен '*' тогда к узлу будут


звезду в бэктики?

qfox · 2016-09-14T22:46:49Z

lib/bemxjst/match.js

  for (var i = 0; i < this.keys.length - 1; i++) {
    val = val[this.keys[i]];
    if (!val)
      return false;
  }

+  if (this.value === '*')


Технически, разницы с точки зрения шаблонизатора нет, но кажется, что лучше всё-таки использовать true, а не '*', потому что консистентность с i-bem onSetMod

onSetMod со значением модификатора true это же не то что проверка подпредиката «есть такой модификатор»… Я могу убрать волшебное слово wildcard, но, мне кажется, лучше оставить специальное значение '*'. Тогда можно будет явно писать mod('size', '*')

Ну черт с ним тогда, но имхо это неконсистентность на уровне onSetMod, и нет смысла делать так же, как и там.

Если же говорить про «явно писать mod('size', '*')» — таким образом у нас 2 способа добиться одного и того же. А зачем?

@zxqfox убрал.

qfox · 2016-09-14T22:48:16Z

test/modes-mod-test.js

@@ -83,5 +83,33 @@ describe('Modes .mod(modName, modVal)', function() {
      { block: 'b', mods: { m: null } },
      '<div class="b"></div>');
    });
+
+    it('should support mod with wildcard', function() {


очень лукаво называть специальное значение строка со звездой вайлдкардом. Вайлдкард позволяет a*, *a, a*a, ??pup etc.

qfox · 2016-09-14T22:49:42Z

Github радует)

miripiruni · 2016-09-19T13:57:49Z

Updated

coveralls · 2016-09-21T12:26:43Z

Coverage increased (+0.007%) to 96.965% when pulling b32aab9 on issue-274__mods-wildcard into b2f14b7 on master.

coveralls · 2016-09-21T12:46:02Z

Coverage increased (+0.007%) to 96.965% when pulling 5f5221f on issue-274__mods-wildcard into b2f14b7 on master.

miripiruni added semver: minor status: review type: new feature labels Sep 12, 2016

miripiruni force-pushed the issue-274__mods-wildcard branch from 2721a93 to 7a48f32 Compare September 12, 2016 14:56

veged reviewed Sep 13, 2016
View reviewed changes

miripiruni force-pushed the issue-274__mods-wildcard branch from 7a48f32 to 34a6223 Compare September 14, 2016 11:48

tadatuta reviewed Sep 14, 2016
View reviewed changes

miripiruni force-pushed the issue-274__mods-wildcard branch from 34a6223 to 288964c Compare September 14, 2016 14:47

qfox requested changes Sep 14, 2016

View reviewed changes

miripiruni force-pushed the issue-274__mods-wildcard branch 2 times, most recently from 9dd1d7b to 354e587 Compare September 19, 2016 13:56

miripiruni force-pushed the issue-274__mods-wildcard branch from 354e587 to b32aab9 Compare September 21, 2016 12:22

Fixed #274: Support mod(m) and elemMod(em) without second argument

5f5221f

miripiruni force-pushed the issue-274__mods-wildcard branch from b32aab9 to 5f5221f Compare September 21, 2016 12:36

miripiruni added this to the 7.3.0 milestone Sep 21, 2016

miripiruni merged commit 61e555b into master Sep 21, 2016

miripiruni deleted the issue-274__mods-wildcard branch September 21, 2016 12:56

miripiruni removed the status: review label Jan 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support `mod(m)` and `elemMod(em)` without second argument #346

Support `mod(m)` and `elemMod(em)` without second argument #346

miripiruni commented Sep 12, 2016 •

edited

Loading

coveralls commented Sep 12, 2016 •

edited

Loading

veged Sep 13, 2016

miripiruni Sep 13, 2016 •

edited

Loading

qfox Sep 13, 2016

veged commented Sep 13, 2016

coveralls commented Sep 14, 2016 •

edited

Loading

tadatuta Sep 14, 2016

miripiruni Sep 14, 2016

miripiruni commented Sep 14, 2016

coveralls commented Sep 14, 2016 •

edited

Loading

qfox left a comment

qfox Sep 14, 2016

miripiruni Sep 20, 2016

qfox Sep 14, 2016

miripiruni Sep 16, 2016

qfox Sep 14, 2016 •

edited

Loading

miripiruni Sep 20, 2016

qfox Sep 14, 2016 •

edited

Loading

miripiruni Sep 20, 2016

qfox Sep 14, 2016

miripiruni Sep 20, 2016

qfox Sep 14, 2016

qfox Sep 14, 2016 •

edited

Loading

qfox Sep 14, 2016

qfox Sep 14, 2016

miripiruni Sep 19, 2016

qfox Sep 20, 2016

qfox Sep 20, 2016

miripiruni Sep 21, 2016

qfox Sep 14, 2016

qfox commented Sep 14, 2016

miripiruni commented Sep 19, 2016

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

		@@ -152,6 +176,10 @@ block('page').elem('content').elemMod('type', 'index').mix()({ block: 'mixed' })

		`elemModVal` проверяются на соответствие после приведения к строке. Это поведение аналогично поведению проверки `modVal`.

		Второй аргумент `elemMods()` также может отстуствовать или быть равен '*', в

Support mod(m) and elemMod(em) without second argument #346

Support mod(m) and elemMod(em) without second argument #346

Conversation

miripiruni commented Sep 12, 2016 • edited Loading

coveralls commented Sep 12, 2016 • edited Loading

Choose a reason for hiding this comment

miripiruni Sep 13, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

veged commented Sep 13, 2016

coveralls commented Sep 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miripiruni commented Sep 14, 2016

coveralls commented Sep 14, 2016 • edited Loading

qfox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qfox Sep 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qfox Sep 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qfox Sep 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qfox commented Sep 14, 2016

miripiruni commented Sep 19, 2016

coveralls commented Sep 21, 2016 • edited Loading

coveralls commented Sep 21, 2016 • edited Loading

Support `mod(m)` and `elemMod(em)` without second argument #346

Support `mod(m)` and `elemMod(em)` without second argument #346

miripiruni commented Sep 12, 2016 •

edited

Loading

coveralls commented Sep 12, 2016 •

edited

Loading

miripiruni Sep 13, 2016 •

edited

Loading

coveralls commented Sep 14, 2016 •

edited

Loading

coveralls commented Sep 14, 2016 •

edited

Loading

qfox Sep 14, 2016 •

edited

Loading

qfox Sep 14, 2016 •

edited

Loading

qfox Sep 14, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading

coveralls commented Sep 21, 2016 •

edited

Loading