bem-xjst: clean cached flags for wrap() and extend() (fix for #495)

CHANGELOG.md

@@ -1,5 +1,10 @@
 # BEM-XJST Changelog
 
+# 2018-04-16 [v8.9.2-rc.1](https://github.com/bem/bem-xjst/compare/v8.9.1...v8.9.2-rc.1), @miripiruni
+
+Release candidate from https://github.com/bem/bem-xjst/pull/496 to check benchmarks on real project.
+
+
 # 2018-03-05 [v8.9.1](https://github.com/bem/bem-xjst/compare/v8.9.0...v8.9.1), @miripiruni
 
 Bug fixed: dot-delimited dependencies from global scope in object notation.

lib/bemxjst/index.js

@@ -19,6 +19,9 @@ function BEMXJST(options) {
   // Current match
   this.match = null;
 
+  this._wraped = [];
+  this._extended = [];
+
   // Create new Context constructor for overriding prototype
   this.contextConstructor = function ContextChild(bemxjst) {
     Context.call(this, bemxjst);
@@ -311,12 +314,26 @@ BEMXJST.prototype._run = function(context) {
   return this.runOne(context);
 };
 
+BEMXJST.prototype.cleanWrapFlags = function(field) {
+  var cached = this[field];
+
+  if (cached.length === 0)
+    return;
+
+  for (var i = 0; i < cached.length; i++)
+    cached[i].wrap = null;
+};
+
 BEMXJST.prototype.run = function(json) {
   var match = this.match;
   var context = this.context;
   var depth = this.depth;
 
   this.match = null;
+
+  this.cleanWrapFlags('_extended');
+  this.cleanWrapFlags('_wraped');
+
   this.context = new this.contextConstructor(this);
   this.canFlush = this.context._flush !== null;
   this.depth = 0;

lib/bemxjst/match.js

@@ -45,6 +45,9 @@ function MatchWrap(template) {
 MatchWrap.prototype.exec = function(context) {
   var res = this.wrap !== context.ctx;
   this.wrap = context.ctx;
+
+  context._bemxjst._wraped.push(this);
+
   return res;
 };
 
@@ -54,8 +57,11 @@ function MatchExtend(template) {
 }
 
 MatchExtend.prototype.exec = function(context) {
-  var res = this.ext !== context.ctx;
-  this.ext = context.ctx;
+  var res = this.wrap !== context.ctx;
+  this.wrap = context.ctx;
+
+  context._bemxjst._extended.push(this);
+
   return res;
 };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bem-xjst",
-  "version": "8.9.1",
+  "version": "8.9.2-rc.1",
   "description": "Declarative Template Engine for the browser and server",
   "keywords": [
     "template",

test/modes-extend-test.js

@@ -81,4 +81,24 @@ describe('Modes extend', function() {
     }, { block: 'b', foo: 'This is' },
     '<div class="b">This is ContextChild</div>');
   });
+
+  it('should work with several apply() calls', function() {
+    var bemjson = { block: 'b1' };
+    var expected = '<div class="b1">42</div>';
+    var tmpl = fixtures.compile(function() {
+      block('b1').extend()({ 'ctx.content': 42 });
+    });
+
+    assert.equal(
+      tmpl.apply(bemjson),
+      expected,
+      'first apply() call returns not expected value'
+    );
+
+    assert.equal(
+      tmpl.apply(bemjson),
+      expected,
+      'second apply() call returns not expected value'
+    );
+  });
 });

test/modes-wrap-test.js

@@ -58,6 +58,30 @@ describe('Modes wrap', function() {
     }, { block: 'b1' }, '<div class="b1"></div>');
   });
 
+  it('should work with several apply() calls', function() {
+    var bemjson = { block: 'b1' };
+    var expected = '<div class="b2"><div class="b1"></div></div>';
+    var tmpl = fixtures.compile(function() {
+      block('b1').wrap()(function() {
+        return {
+          block: 'b2',
+          content: this.ctx
+        };
+      });
+    });
+
+    assert.equal(
+      tmpl.apply(bemjson),
+      expected,
+      'first apply() call returns not expected value'
+    );
+
+    assert.equal(
+      tmpl.apply(bemjson),
+      expected,
+      'second apply() call returns not expected value'
+    );
+  });
 
   it('should use current context (with simple value)', function() {
     test(function() {