Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEMHTML: cls and bem:false fix #499

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Conversation

miripiruni
Copy link
Contributor

Fix for #498

@miripiruni
Copy link
Contributor Author

cc @tadatuta @vill

@@ -68,4 +68,15 @@ describe('BEMJSON bem', function() {
{ block: 'b', bem: [ 1, 2 ] },
'<div class="b"></div>');
});

it('should out cls value if bem:false', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out -> output?

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 99.387% when pulling ab0b7b7 on issue-498__cls-bem-fix into 36e253c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.387% when pulling 3580d5b on issue-498__cls-bem-fix into 36e253c on master.

@miripiruni miripiruni merged commit aae5243 into master Feb 1, 2018
@miripiruni miripiruni deleted the issue-498__cls-bem-fix branch February 1, 2018 14:46
@miripiruni miripiruni added this to the 8.8.6 milestone Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants