Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class i-bem on elems with js #122

Merged
merged 1 commit into from
Mar 16, 2015
Merged

Class i-bem on elems with js #122

merged 1 commit into from
Mar 16, 2015

Conversation

mishanga
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.73% when pulling b1c4fad on jselem into c1bd846 on master.

@mishanga
Copy link
Member Author

/cc @denchistyakov @matmuchrapna @narqo
Для bem-core@v3 потребовалось обратно вернуть класс i-bem на элементах.

@mishanga
Copy link
Member Author

@xdghcnt

});

it('should use empty jsCls option', function() {
bh.setOptions({ jsCls: '' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false или null не понятнее?

mishanga added a commit that referenced this pull request Mar 16, 2015
Class `i-bem` on elems with `js`
@mishanga mishanga merged commit 7ca71a7 into master Mar 16, 2015
@mishanga mishanga deleted the jselem branch March 16, 2015 14:14
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
qfox pushed a commit to bem/bh-php that referenced this pull request Apr 23, 2015
- Added global matcher support: `beforeEach` and `afterEach` (bem/bh#121).
- Added `ctx.process` method (bem/bh#135).
- Add `i-bem` class to element with `js` (bem/bh#122).
- No-base modifier classes supported (bem/bh#132).
- `processBemJson` now return standart BEMJSON (bem/bh#96).

Changelog bem/bh@ee446ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants