Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delimElem and delimMod options for custom bem syntax #150

Merged
merged 1 commit into from
Jun 8, 2015
Merged

delimElem and delimMod options for custom bem syntax #150

merged 1 commit into from
Jun 8, 2015

Conversation

sladex
Copy link

@sladex sladex commented Jun 5, 2015

Will fix #128

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fcb7cac on sladex:custom-naming into b70bfea on bem:master.

mishanga
mishanga reviewed Jun 5, 2015
View reviewed changes
README.md
@@ -197,6 +197,30 @@ bh.apply({ content: '<script>' });
<div>&lt;script&gt;</div>
```

### delimEl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай назовем delimElem

@mishanga
Copy link
Member

mishanga commented Jun 5, 2015

@innabelaya Инна, можешь помочь с формулировками в README?

@mishanga
Copy link
Member

mishanga commented Jun 5, 2015

По реализации ок.

@innabelaya
Copy link
Contributor

@mishanga Миша, новом тексте все хорошо. Или надо просмотреть весь файл?

@mishanga
Copy link
Member

mishanga commented Jun 6, 2015

@innabelaya нет, только новые изменения.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bccd821 on sladex:custom-naming into b70bfea on bem:master.

@blond
Copy link
Member

blond commented Jun 6, 2015

А мы точно не хотим заиспользовать bem-naming ? :)

@qfox
Copy link
Member

qfox commented Jun 8, 2015

@blond под php нету библиотеки, поэтому не)

@sladex sladex changed the title delimEl and delimMod options for custom bem syntax delimElem and delimMod options for custom bem syntax Jun 8, 2015
@sladex
Copy link
Author

sladex commented Jun 8, 2015

delimEl в delimElem переименовал.

@blond
Copy link
Member

blond commented Jun 8, 2015

под php нету библиотеки, поэтому не)

@zxqfox А затраншпилить? =)

@mishanga
Copy link
Member

mishanga commented Jun 8, 2015

@blond не-не-не, никаких bem-naming.

mishanga added a commit that referenced this pull request Jun 8, 2015
@mishanga
Merge pull request #150 from sladex/custom-naming
c64baf3 
delimElem and delimMod options for custom bem syntax
@mishanga mishanga merged commit c64baf3 into bem:master Jun 8, 2015
@blond
Copy link
Member

blond commented Jun 8, 2015

@mishanga, а если с аргументами? )

@mishanga
Copy link
Member

mishanga commented Jun 8, 2015

Не хочется лишних зависимостей.

@blond
Copy link
Member

blond commented Jun 8, 2015

Можно же собирать зависимости, так что ни для пользователей ничего не изменится, ни в тестировании.

@qfox
Copy link
Member

qfox commented Jun 8, 2015

@blond оффтоп, но траншпилить сложно, потому что в пхп массивы иммутабельные. Не невозможно, конечно, просто дорого.

@blond
Copy link
Member

blond commented Jun 9, 2015

@zxqfox, так может тогда наоборот написать bem-naming на php? =)

@pavelpower
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom bem-naming syntax
7 participants
@sladex @coveralls @mishanga @innabelaya @blond @qfox @pavelpower