Возможность устанавливать токены и сбрасывать их до изначального состояния #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nnigmat
force-pushed
the
observer.reset-tokens
branch
from
9dd873b
to
1284f83
Compare
Nnigmat
changed the title
Nnigmat
force-pushed
the
observer.reset-tokens
branch
from
f4bf06a
to
e0c59d5
Compare
Nnigmat
commented
Sep 2, 2021
| private options: CompileOptions | ||
| private compile: Compile | ||
| private watchers: Set<Watcher> = new Set() | ||
|
|
||
| constructor(options: CompileOptions, _compile: Compile = compile) { | ||
| this.compile = _compile | ||
| this.options = options | ||
| this.options = deepcopy(options) |
There was a problem hiding this comment.
Здесь deepcopy, потому что у нас происходила мутация данных пользователя. Я столкнулся с этим во время запуска тестов, токены из одного теста были в другом.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Есть необходимость устанавливать токены и сбрасывать их.
Это можно делать в приложении, но это слишком громоздко из-за эффектора, нужно пересоздавать
observerи заново навешивать на него watcher'ы и удалять старые.