Remove locked column of extensions table from update sql - my mistake #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#29235.
Summary of Changes
Remove the locked column from the insert statements into the extensions table in the update SQL script - was my mistake, I had forgotten that the update SQL script which adds this column runs after the one of ther workflows.
Testing Instructions
Update a 3.10-dev with the update container built for PR joomla#29235 .
Expected result
No SQL error about the "locked" column.
Actual result
Error "Unknown column 'locked' in 'field list'" shown in the middle uf the SQL updates, which breaks the update and leave a broken database.
Documentation Changes Required
None.