New Plugin workflow_notification #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bembelimen
requested changes
May 9, 2020
administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-05-15.sql
Outdated
Show resolved
Hide resolved
richard67
reviewed
May 10, 2020
ty Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
bembelimen
reviewed
May 10, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
bembelimen
reviewed
May 19, 2020
|
@chmst Your update SQL skripts still use real null values for the checked out time of the extensions table, but it should use the old fashioned null dates because the change to real null values for that database column is done with a schema update sql which runs later. |
|
See joomla#26428 !!! |
|
@bembelimen If your workflow-v3 branch is not up to date with the 4.0-dev branch of the CMS so that it contains the changes from PR joomla#26428 , then please update your branch, otherwise this mistake will happen again and again. |
# Conflicts: # administrator/components/com_admin/sql/updates/mysql/4.0.0-2018-05-15.sql # administrator/components/com_admin/sql/updates/postgresql/4.0.0-2018-05-15.sql
|
Thanks |
bembelimen
pushed a commit
that referenced
this pull request
Dec 7, 2020
bembelimen
pushed a commit
that referenced
this pull request
Dec 7, 2020
- Remove display:grid for top and bottom positions -> improve display for mod_news on top-a - Move rtl definition for footer to _footer.scss ([dir=rtl] & ) - Add margin to form control-group - #92 - Add underline for links without class (e.g. in text) -> #98 - Improve underline rules for links on menus -> #97 - Change padding and position for mod-list on sidebar - Improve links in mod-menu on sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #87 .
Summary of Changes
This plugin adds a tab to workflow transitions.
It is possible for every transition
Testing Instructions
As the plugin is new, it first must be installed.
Then every transition must have a new tab "notofication".
Enter your data and watch the private messages
Private messages are displayed not correctly but this is not in scope of this PR.
NOTE: The function has been removed from the content plugn joomla. It musbe tested if this works as before.
Expected result
All data are delivered and sent to all receivers, but only once.
Actual result
Documentation Changes Required
yes