Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included Instructions to Run on Local Machine #490

Merged
merged 5 commits into from
Jun 9, 2018

Conversation

Coppertine
Copy link
Contributor

Instructions are included to Run on a Local Machine using XAMPP (Windows Use)

Instructions are included to Run on a Local Machine using XAMPP (Windows Use)
fixed Gramatical and Spelling Errors
@codecov-io
Copy link

codecov-io commented Jun 9, 2018

Codecov Report

Merging #490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         170      170           
  Lines        5370     5370           
  Branches        1        1           
=======================================
  Hits         4516     4516           
  Misses        854      854

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8442813...8f4075b. Read the comment docs.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Before we could merge this PR, kindly make the following changes.

<p>Make sure you create a Backup of the file so that you can restore to the default settings if any issues occur.</p>
</div>

Find the Varable name `DocumentRoot` and edit it's value from `"C:\xampp\htdocs"` to your server folder. (e.g. `C:\Bemuse\myserver`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varable -> variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -50,6 +50,7 @@ $ sox --version
* [SoX](http://sox.sourceforge.net/): Download from http://sourceforge.net/projects/sox/files/sox/
* [QuickTime Player](http://www.apple.com/quicktime/download/) or [iTunes](http://www.apple.com/itunes/download/)
* [qaac](https://sites.google.com/site/qaacpage/)
* [xampp](https://www.apachefriends.org) **For Hosting on your Local Machine**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this would look better if we made it like this:

* [qaac]

For hosting on your local machine:

* [xampp](https://www.apachefriends.org)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed





Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the excessive lines here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, Even though The Wiki removes them in the web preview

Fixed Spelling Mistake
Fixed Prerequisite from Suggestion
Excessive Lines Removed
@resir014
Copy link
Member

resir014 commented Jun 9, 2018

All good now. Thanks for your help! ❤️

@resir014 resir014 merged commit d0cd68e into bemusic:master Jun 9, 2018
resir014 added a commit that referenced this pull request Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants