-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included Instructions to Run on Local Machine #490
Conversation
Instructions are included to Run on a Local Machine using XAMPP (Windows Use)
fixed Gramatical and Spelling Errors
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 170 170
Lines 5370 5370
Branches 1 1
=======================================
Hits 4516 4516
Misses 854 854 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Before we could merge this PR, kindly make the following changes.
docs/music-server.md
Outdated
<p>Make sure you create a Backup of the file so that you can restore to the default settings if any issues occur.</p> | ||
</div> | ||
|
||
Find the Varable name `DocumentRoot` and edit it's value from `"C:\xampp\htdocs"` to your server folder. (e.g. `C:\Bemuse\myserver`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
varable -> variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
docs/music-server.md
Outdated
@@ -50,6 +50,7 @@ $ sox --version | |||
* [SoX](http://sox.sourceforge.net/): Download from http://sourceforge.net/projects/sox/files/sox/ | |||
* [QuickTime Player](http://www.apple.com/quicktime/download/) or [iTunes](http://www.apple.com/itunes/download/) | |||
* [qaac](https://sites.google.com/site/qaacpage/) | |||
* [xampp](https://www.apachefriends.org) **For Hosting on your Local Machine** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this would look better if we made it like this:
* [qaac]
For hosting on your local machine:
* [xampp](https://www.apachefriends.org)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
docs/music-server.md
Outdated
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the excessive lines here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, Even though The Wiki removes them in the web preview
Fixed Spelling Mistake
Fixed Prerequisite from Suggestion
Excessive Lines Removed
All good now. Thanks for your help! ❤️ |
Instructions are included to Run on a Local Machine using XAMPP (Windows Use)