-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Deps upgrade - v42 edition #498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
======================================
Coverage 84.1% 84.1%
======================================
Files 171 171
Lines 5387 5387
Branches 1 1
======================================
Hits 4531 4531
Misses 856 856
Continue to review full report at Codecov.
|
I am fixing the merge conflicts. |
Cool. It might be also safe to rebuild the |
@resir014 You mean, rebuild |
Actually nevermind. I just realised it's been done on the other PR 😅 |
I am having trouble with the internet connection right now ( That means before merging, we have to run |
Okay, take your time. I'm probably be out all day today as well and will be
back on my computer later tonight.
…On Sun, 14 Oct 2018, 14:09 Thai Pangsakulyanont, ***@***.***> wrote:
I am having trouble with the internet connection right now (yarn install
won’t finish and stuck at building puppeteer), so I reverted yarn.lock to
current master for now.
That means before merging, we have to run yarn.lock (either rebuild from
scratch or using the master version) to update it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#498 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFZshSasLkEZQaCJJZfNdNlTYUWan5voks5ukuM1gaJpZM4XCc-c>
.
|
Thanks! I think we can merge this now.
|
Some more upgrades for our dependencies + devDependencies.