Use NDEBUG version of stbvorbis.js #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 156 156
Lines 4760 4760
Branches 184 184
=======================================
Hits 3849 3849
Misses 862 862
Partials 49 49
Continue to review full report at Codecov.
|
dtinth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, when decoding OGG using stbvorbis.js, an assertion error occurred. It’s very strange that it doesn’t happen on Safari for Mac. As a “hacky” fix, I disabled assertions and recompiled the library using
-DNDEBUGflag. It is not elegant… but it works. 😂Changelog
Fixed an issue where the OGG sound decoder crashes when decoding some OGG files in iOS.