Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action for lint, test and test_packages jobs #718

Merged
merged 7 commits into from
Oct 26, 2021
Merged

Add Github Action for lint, test and test_packages jobs #718

merged 7 commits into from
Oct 26, 2021

Conversation

vtno
Copy link
Contributor

@vtno vtno commented Oct 24, 2021

Closes #692

  • Add lint job
  • Add test job
  • Add test_packages job
  • Cache dependencies between jobs

Changelog

Migrated some workflows from CircleCI to GitHub Actions to speed up builds.

@vtno vtno marked this pull request as ready for review October 25, 2021 18:18
@vtno
Copy link
Contributor Author

vtno commented Oct 25, 2021

@dtinth Could you help trigger the build? It requires maintainer approval. I'm also thinking of working on the cahce as a separate task so this could be merge early. The job run quite quickly already. What do you think?

@dtinth
Copy link
Member

dtinth commented Oct 25, 2021

@vtno Thanks — I have approved the run!

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and two minutes is really fast! I will get this in for now, thanks!

@vtno
Copy link
Contributor Author

vtno commented Oct 25, 2021

@dtinth Awesome! Thanks for the review.

@vtno vtno closed this Oct 25, 2021
@vtno vtno reopened this Oct 25, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vtno
Copy link
Contributor Author

vtno commented Oct 25, 2021

@dtinth I can see on the codecov job these logs

==> Building file structure
==> Generating gcov reports (skip via --disable=gcov)
    $ find /home/runner/work/bemuse/bemuse -type f -name '*.gcno'  -exec gcov  {} +
==> Scanning for reports
    + /home/runner/work/bemuse/bemuse/bemuse/coverage/lcov.info
    + /home/runner/work/bemuse/bemuse/packages/bemuse-tools/coverage/lcov.info
    + /home/runner/work/bemuse/bemuse/packages/bemuse-indexer/coverage/lcov.info
    + /home/runner/work/bemuse/bemuse/packages/bms/coverage/lcov.info
    + /home/runner/work/bemuse/bemuse/packages/bemuse-notechart/coverage/lcov.info
    + /home/runner/work/bemuse/bemuse/packages/bmson/coverage/lcov.info
==> Uploading reports
    Could not determine repo and owner

Do you need to setup some ENV for this to upload properly?

@dtinth
Copy link
Member

dtinth commented Oct 26, 2021

@vtno Yes, I will take care of it, thanks! :)

@dtinth dtinth merged commit 6e863a4 into bemusic:master Oct 26, 2021
@vtno vtno deleted the github-action branch October 26, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate lint, test, test_packages jobs from CircleCI to GitHub Actions
2 participants