Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svgo@3 #129

Closed
wants to merge 1 commit into from
Closed

Update svgo@3 #129

wants to merge 1 commit into from

Conversation

pioug
Copy link

@pioug pioug commented Dec 22, 2022

The breaking changes for svgo are described in https://github.com/svg/svgo/releases/tag/v3.0.0. I updated some tests accordingly.

There many additions in the package-lock.json apparently it wasn't synced previously.

npm ERR! code EUSAGE
npm ERR! 
npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
....

@rejas @ben-eb Would you accept my help to maintain this project? I can do the basic chores and regularly update the project. Many of my work projects depend on gulp-svgmin, so I am happy to keep it healthy.

@rejas
Copy link
Collaborator

rejas commented Dec 27, 2022

Hi @pioug I wouldnt mind passing my torch over to you since I dont really use gulp / gulp plugins anymore. But maybe moving this plugin to https://github.com/gulp-community might be an idea too?

@pioug
Copy link
Author

pioug commented Dec 27, 2022

Thanks for your reply @rejas !

The gulp-community doesn't seem very active 💦 The idea is good, but as is often the case with OSS projects, it's difficult to predict how long someone will be able to commit to the project.

I'd be happy to take on the maintenance of gulp-svgmin 🙌

If it's not too much to ask, I would need push permissions for the repository and publish permissions for npm (https://www.npmjs.com/~pioug).

If you make me an admin, I could also invite other contributors in the future too 🤔, but the decision is ultimately up to you!

@rejas
Copy link
Collaborator

rejas commented Dec 29, 2022

the community might no tbe very active, but @phated seems to be quick to respond

but in the end its up to @ben-eb to decide how to move forward from this, since I dont have enough maintainership myself to do that.

@rejas rejas mentioned this pull request Feb 17, 2023
@pioug pioug closed this by deleting the head repository Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants