Add ticket-id-complement input #31
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r parallel/matrix jobs in the same workflow run
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- rootfs/scripts/lock.sh: Language not supported
ben-z
reviewed
Jan 8, 2025
| @@ -29,6 +29,10 @@ inputs: | |||
| description: '[Internal] The location to store the mutex repo' | |||
| required: false | |||
| default: '/run/gh-action-mutex/repo' | |||
| ticket-id-complement: | |||
There was a problem hiding this comment.
Suggested change
| ticket-id-complement: | |
| ticket-id-suffix: |
Since this is the suffix, let's just name it "suffix".
| ticket-id-complement: | ||
| description: 'Ticket id suffix to avoid identical values for parallel/matrix jobs in the same workflow run' | ||
| required: false | ||
| default: '' |
There was a problem hiding this comment.
Suggested change
| default: '' | |
| default: 'default' |
This is to make sure that we don't have ticket ids that end in -. This should help with clarity and debugging in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ticket-id-complement input to avoid identical ticket_id value for parallel/matrix jobs in the same workflow run.
Motivation: Parallel/Matrix jobs could generate the same ticket_id, meaning multiple parallel jobs in the same workflow run could gain access to a resource at the same time. The new input allows adding a suffix to the ticket_id, allowing different values being generated for different jobs.
Resolves #32