fix: use isVisible helper to exclude hidden elements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden elements should be excluded from tab order. Hidden attribute can be overwritten by stylesheets. There is a bug in jsdom that has to be resolved first. See jsdom/jsdom#3111
4 tasks
Trigger click event for userEvent.type('{enter}') on HTMLAnchorElements.
Co-authored-by: Philipp Fritsche <ph.fritsche@gmail.com>
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Philipp Fritsche <ph.fritsche@gmail.com>
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
This reverts commit d513d6e.
…brary#567) * fix(click): focus closest focusable * refactor: remove redundant check
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* fix(upload): apply accept attribute (testing-library#558) * fix(upload): make accept filter opt-in * docs(upload): add options.applyAccept * fix(typing): add options.applyAccept Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
Finally jsdom@16.5.0 is released with the fix. |
* docs: update README.md * docs: update .all-contributorsrc Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden elements should be excluded from tab order.
Hidden attribute can be overwritten by stylesheets.
There is a bug in jsdom that has to be resolved first.
See jsdom/jsdom#3111