Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add staff and contributor badges #2654

Merged
merged 32 commits into from
May 12, 2021
Merged

Conversation

amitojsingh366
Copy link
Contributor

@amitojsingh366 amitojsingh366 commented May 8, 2021

  • adds staff and contributor badges
  • adds admin panel where you can ban ppl or allot them staff/contributor badges
  • added tests

will add translation keys in another pr so the diff isn't super hard to read

@vercel
Copy link

vercel bot commented May 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

staging – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-staging/staging/7MwUr86Qg8BnFjX5CrJfw7kLY7LA
✅ Preview: https://staging-git-fork-amitojsingh366-patch-53-dogehouse-staging.vercel.app

[Deployment for 826c4eb canceled]

dogehouse – ./kibbeh

🔍 Inspect: https://vercel.com/benawad/dogehouse/Aoman29cT6FqVUVqbLmMsD316JbB
✅ Preview: https://dogehouse-git-fork-amitojsingh366-patch-53-benawad.vercel.app

storybook – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/9EmW8PVcwNdRUw4TpLrCtTFQby6R
✅ Preview: https://storybook-git-fork-amitojsingh366-patch-53-dogehouse-storybook.vercel.app

[Deployment for 826c4eb canceled]

@vercel vercel bot temporarily deployed to Preview – storybook May 8, 2021 18:31 Inactive
@github-actions github-actions bot added kebab Related to the API client kibbeh Related to the UI design implementation kousa Issues related to the elixir API labels May 8, 2021
kousa/test/broth/_message/user/admin_update_test.exs Outdated Show resolved Hide resolved

cond do
not is_nil(staff) and not is_nil(contributions) ->
case user_to_change
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin_update_with should function like update_with where you just pass the changeset in, you don't need case statements

user_to_change = Users.get_by_username(username_to_change)

^that should go in initialize

  def initialize(state) do
    Users.get_by_username(username_to_change)
  end

This might be tricky for you to figure out, I'll convert it over if you get stuck

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kebab Related to the API client kibbeh Related to the UI design implementation kousa Issues related to the elixir API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants