-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add staff and contributor badges #2654
Conversation
This pull request is being automatically deployed with Vercel (learn more). staging – ./kibbeh🔍 Inspect: https://vercel.com/dogehouse-staging/staging/7MwUr86Qg8BnFjX5CrJfw7kLY7LA [Deployment for 826c4eb canceled] dogehouse – ./kibbeh🔍 Inspect: https://vercel.com/benawad/dogehouse/Aoman29cT6FqVUVqbLmMsD316JbB storybook – ./kibbeh🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/9EmW8PVcwNdRUw4TpLrCtTFQby6R [Deployment for 826c4eb canceled] |
|
||
cond do | ||
not is_nil(staff) and not is_nil(contributions) -> | ||
case user_to_change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin_update_with should function like update_with where you just pass the changeset in, you don't need case statements
user_to_change = Users.get_by_username(username_to_change)
^that should go in initialize
def initialize(state) do
Users.get_by_username(username_to_change)
end
This might be tricky for you to figure out, I'll convert it over if you get stuck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
will add translation keys in another pr so the diff isn't super hard to read