Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gem name in config #3

Merged
merged 1 commit into from
Sep 2, 2017
Merged

Conversation

KevinTCoughlin
Copy link
Contributor

@KevinTCoughlin KevinTCoughlin commented Sep 2, 2017

First off, thanks for this awesome gem and your work w/ Jekyll 😄. Took me a few to realize this is why I couldn't get the gem to run while profiling via jekyll build --profile.

@KevinTCoughlin
Copy link
Contributor Author

🤔

Failures:
  1) JekyllIncludeCache with an empty cache initializess the cache
     Failure/Error: before { described_class.remove_instance_variable("@cache") }
     
     NameError:
       instance variable @cache not defined
     # ./spec/jekyll-include-tag_spec.rb:3:in `remove_instance_variable'
     # ./spec/jekyll-include-tag_spec.rb:3:in `block (3 levels) in <top (required)>'
Finished in 0.05425 seconds (files took 0.67191 seconds to load)
11 examples, 1 failure
Failed examples:
rspec ./spec/jekyll-include-tag_spec.rb:5 # JekyllIncludeCache with an empty cache initializess the cache

@benbalter
Copy link
Owner

Thanks for this @KevinTCoughlin! That failing test is likely an order dependency and unrelated.

@benbalter benbalter merged commit 4bee013 into benbalter:master Sep 2, 2017
@KevinTCoughlin KevinTCoughlin deleted the patch-1 branch September 2, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants