-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use themes hosted on enterprise GitHub instances. #53
Conversation
Welcome! Congrats on your first pull request to Jekyll Remote Theme. If you haven't already, please be sure to check out the contributing guidelines. |
Thanks for this @jallenwork. Curious, do you need to be able to pull from multiple enterprise instances, or could the host be set in the config file as an override? |
I personally don't have any need to use multiple enterprise instances, so for my use case a config file override would work fine. Would you prefer that the host get it's own entry in _config.yml? |
@jallenwork really appreciate the PR. Based on your work, I pushed up a minor refactor that I think makes things a bit more readable and user friendly. Now, themes can be in the form of If no host is supplied, github.com is assumed. If a host is supplied, it must be the GitHub Enterprise instance which the site is being built on (to prevent builds on GitHub.com being sent to a malicious server). We always download from Does that make sense / meet your needs? |
@benbalter This looks great, thanks for putting in the extra effort on this, I really appreciate it. This should work famously for myself and others running GH Enterprise instances. |
Congrats on getting your first pull request to Jekyll Remote Theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
From reading through the comments and by administering a GitHub Enterprise Server for a number of years, I think I have an understanding of the requirements for hosting remote themes on GHES, but I thought I'd double-check my understanding. The comments mention Also, the code, I think, mentions that the repo hosting the remote must be "public." The term public can mean a few things, depending on how your GHES is configured, but I'm assuming that it means that the repo hosting the remote theme must not require authentication of any kind. GHES's that either don't have subdomain isolation enabled or are using private mode can't use this approach. |
I'd like to use this for repos hosted in our enterprise instance at work (as would several of my coworkers) so I thought I would throw this against the wall and see if it stuck. I'm not a ruby programmer, so any stylistic feedback is welcome.
Fixes #43
View rendered README.md