Add support for nested sitemaps #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having to download files over the network we can stub Typhoeus so that the tests work without an internet connection.
Rescuing all exceptions makes it quite hard to figure out the intended purpose of the code and could mask more serious problems.
This will be helpful when we support sitemapindex.
I've defaulted this option to false to maintain the current behaviour. This is limited to one level for now so that we don't do infinite recursing of sitemaps.
|
This looks great. Thanks @alexmuller! |
|
Thank you very much! Would you mind pushing a release of this to RubyGems? I'd love to give it a go in https://github.com/alphagov/govuk_seed_crawler/. |
|
Done: https://github.com/benbalter/sitemap-parser/releases/tag/v0.3.0 And thanks for tidying up the tests! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've ended up rejigging a bit here, I hope that's ok. There's probably better ways of doing this but I believe this works!
There's more detail in the commit messages.