Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to parse local sitemap regardless of filename #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsmsogn
Copy link

@tsmsogn tsmsogn commented Feb 27, 2017

This PR has following features.

@tsmsogn tsmsogn changed the title Enable to parsing local sitemap regardless of filename Enable to parse local sitemap regardless of filename Feb 27, 2017
@tsmsogn tsmsogn force-pushed the features/local_sitemap branch from 9852a5b to 525a4d1 Compare February 27, 2017 03:54
@benbalter
Copy link
Owner

Based on the error in #14, I wonder if we need to call File.expan_path on @url such that the URL is prefexed by a / in all cases.

@tsmsogn
Copy link
Author

tsmsogn commented Feb 28, 2017

Thank you for your reply.

Should I close this PR, then split this PR into two PRs?
One fixes #14 with File.expan_path, and the other enables to parse sitemap regardless of file name.

@benbalter
Copy link
Owner

and the other enables to parse sitemap regardless of filename

Can you explain a bit more about why you need to do that?

@tsmsogn
Copy link
Author

tsmsogn commented Mar 1, 2017

Can you explain a bit more about why you need to do that?

There are two reasons.

  1. I think sitemap can have various file name. For example, It is used in sitemap index.
  2. I'd like to parse sitemap in local regardless of file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants