Always close pipe reader on WriteWALSegment return

The pipe writer will deadlock if writing out the WAL segment fails for any reason.
benbjohnson · Nov 15, 2023 · 5e9c94f · 5e9c94f
1 parent 69e435b
commit 5e9c94f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/replica.go b/replica.go
@@ -238,6 +238,12 @@ func (r *Replica) syncWAL(ctx context.Context) (err error) {
 	var g errgroup.Group
 	g.Go(func() error {
 		_, err := r.Client.WriteWALSegment(ctx, pos, pr)
+
+		// Always close pipe reader to signal writers.
+		if e := pr.CloseWithError(err); err == nil {
+			return e
+		}
+
 		return err
 	})