Use structured logging with slog #475
Conversation
|
@benbjohnson I whipped this together based on our conversation earlier. There's a few caveats like with Replica not having the Client on creation time requiring (for now) to use a function to build the logger each time it is used. Some numbers like the WAL index could probably be improved by making it a type alias and having a log formatter function (automatically used by slog) to format it as hex without needing to call Open for initial comments about the whole thing and suggestions what to improve. |
hifi
force-pushed
the
for-upstream/slog-logging
branch
3 times, most recently
from
340847e to
4f89a99
Compare
|
@benbjohnson rebased and cleaned up, let me know what you think! |
Configuration file can set the logging handler between two: text, which is the default, and json. Default level is info which matches previous behavior. A bit more info level logging is enabled by default to default restore to being verbose compared to quiet and snapshotting. Trace logging has been converted to be on DEBUG level and always enabled if the configured level is high enough. Bumps Go requirement to 1.21
hifi
force-pushed
the
for-upstream/slog-logging
branch
from
4f89a99 to
f6fe7c4
Compare
|
|
||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "io" | ||
| "log" |
There was a problem hiding this comment.
"log" package is still used; see lines 38-41,49.
There was a problem hiding this comment.
Right, the Windows build isn't built anymore but the code still exists. It's basically unmaintained so I didn't notice it since I didn't do a Windows build.
I guess it could be fixed but it doesn't really change much.
There was a problem hiding this comment.
For what it's worth, Litestream works just fine on Windows after adding imports.
| @@ -63,13 +62,13 @@ func (s *windowsService) Execute(args []string, r <-chan svc.ChangeRequest, stat | |||
| // Instantiate replication command and load configuration. | |||
| c := NewReplicateCommand() | |||
| if c.Config, err = ReadConfigFile(DefaultConfigPath(), true); err != nil { | |||
| log.Printf("cannot load configuration: %s", err) | |||
| slog.Error("cannot load configuration", "error", err) | |||
Configuration file can set the logging handler between two: text, which is the default, and json. Default level is info which matches previous behavior.
A bit more info level logging is enabled by default to default restore to being verbose compared to quiet and snapshotting.
Trace logging has been converted to be on DEBUG level and always enabled if the configured level is high enough.
Bumps Go requirement to 1.20
Some example output with the default text handler and info level: