Never expect the replica iterators to be sorted #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifi
force-pushed
the
fix/unsorted-wal-segments
branch
from
73fbfc0 to
605dbab
Compare
hifi
changed the title
benbjohnson
approved these changes
Dec 18, 2023
We will never trust the order of anything anymore and always sort them on use when it matters. When it doesn't we can use the potentially unsorted iterator. Documentation for replica interface has been updated to match. Some S3 implementations, like Storj, don't return objects in order unlike the real S3 API. It's against AWS documentation but they have their reasons not to pre-sort them. Since there's only one place where the order matters and we're going to iterate all of them anyway and there's a sort implementation for a WAL segment slice we can do just that to add compatibility without any meaningful performance hit. This also helps implementing new native replica implementations where sorting may not be available. Fixes benbjohnson#535
hifi
force-pushed
the
fix/unsorted-wal-segments
branch
from
605dbab to
9654c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will never trust the order of anything anymore and always sort them on use when it matters. When it doesn't we can use the potentially unsorted iterator. Documentation for replica interface has been updated to match.
Some S3 implementations, like Storj, don't return objects in order unlike the real S3 API. It's against AWS documentation but they have their reasons not to pre-sort them.
Since there's only one place where the order matters and we're going to iterate all of them anyway and there's a sort implementation for a WAL segment slice we can do just that to add compatibility without any meaningful performance hit.
This also helps implementing new native replica implementations where sorting may not be available.
Fixes #535