ENH: add to_wkb / from_wkb

[jorisvandenbossche]

Depends on paleolimbot/s2geography#42

Closes #38

[jorisvandenbossche]

The upstream change is merged in s2georaphy, so this should be ready now

[benbovy]

Thanks @jorisvandenbossche! Two minor comments below.

[benbovy]

Use unique_ptr instead of shared_ptr? (Also in ToWKB) Unless I'm missing something?

[jorisvandenbossche]

It might be that pybind11 requires this class to be copyable? (if you pass it as argument to vectorize)
And that then gives the typical "use of deleted function" compilation errors if using unique_ptr instead of shared_ptr

[benbovy]

It might be that pybind11 requires this class to be copyable? (if you pass it as argument to vectorize)

Ah yes I see. Another option may be to add a FromWKB copy constructor (since this is what is passed to py::vectorize) although using a shared pointer is certainly fine.

[jorisvandenbossche]

I would personally leave it as is with a shared pointer then, to not make the small class more complicated (I don't think instantiation of the vectorized function is performance sensitive?)