Skip to content

Commit

Permalink
Remove duplicated handling of /url result links (#769)
Browse files Browse the repository at this point in the history
It appears that result links beginning with '/url' were mistakenly
commited with an inefficient filtering process in its place. With the
way the code is structured, this less effective '/url' link filter took
precedence over the previous link filter, and also caused users with the
"open link in new tab" config enabled to no longer have access to that
feature.

Fixes #769
  • Loading branch information
jacr13 authored May 25, 2022
1 parent 9bcd993 commit fb6627a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,6 @@ def update_link(self, link: Tag) -> None:
# Internal google links (i.e. mail, maps, etc) should still
# be forwarded to Google
link['href'] = 'https://google.com' + q
elif link['href'].startswith('/url'):
link['href'] = q
elif q.startswith('https://accounts.google.com'):
# Remove Sign-in link
link.decompose()
Expand Down

0 comments on commit fb6627a

Please sign in to comment.