Fix: keep blank values as True to handle blank 'q' input. #1052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (potentially) Issue #1050.
Location of the bug found at the function:
What happened when searching the query “Mathias Normann” (and potentially could be other queries) is that the
href
contains"q"
but the value is blank in bothhref
andq_str
as follows:Thus, the value of ‘q’ would be blank.
By default, the function
parse_qs
will not keep the blank values nor keys, thus making the resultingparse_qs(q_str)['q'][0]
throwing aKeyError
because the key ‘q’ is simply not there.To fix this, I simply put the
keep_blank_values
parameter of theparse_qs
function intoTrue
. This fixes the problem.Some screenshots:
Open to discussions and modifications if needed.