-
-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: description in opensearch template #1175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker_tests failed due to a unrelated error for missing deps: Details
#15 [builder 5/5] RUN pip install --prefix /install --no-warn-script-location --no-cache-dir -r requirements.txt
#15 0.440 Traceback (most recent call last):
#15 0.440 File "/usr/local/bin/pip", line 8, in <module>
#15 0.440 sys.exit(main())
#15 0.440 ^^^^^^
#15 0.440 File "/usr/local/lib/python3.11/site-packages/pip/_internal/cli/main.py", line 78, in main
#15 0.440 command = create_command(cmd_name, isolated=("--isolated" in cmd_args))
#15 0.441 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.441 File "/usr/local/lib/python3.11/site-packages/pip/_internal/commands/__init__.py", line 114, in create_command
#15 0.441 module = importlib.import_module(module_path)
#15 0.441 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.441 File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
#15 0.441 return _bootstrap._gcd_import(name[level:], package, level)
#15 0.441 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.441 File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
#15 0.441 File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
#15 0.441 File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
#15 0.441 File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
#15 0.441 File "<frozen importlib._bootstrap_external>", line 924, in exec_module
#15 0.441 File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
#15 0.441 File "/usr/local/lib/python3.11/site-packages/pip/_internal/commands/install.py", line 16, in <module>
#15 0.441 from pip._internal.cli.req_command import (
#15 0.441 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.441 File "/usr/local/lib/python3.11/site-packages/pip/_internal/cli/req_command.py", line 19, in <module>
#15 0.441 from pip._internal.index.package_finder import PackageFinder
#15 0.441 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.441 File "/usr/local/lib/python3.11/site-packages/pip/_internal/index/package_finder.py", line 31, in <module>
#15 0.442 from pip._internal.req import InstallRequirement
#15 0.442 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.442 File "/usr/local/lib/python3.11/site-packages/pip/_internal/req/__init__.py", line 9, in <module>
#15 0.442 from .req_install import InstallRequirement
#15 0.442 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.442 File "/usr/local/lib/python3.11/site-packages/pip/_internal/req/req_install.py", line 41, in <module>
#15 0.442 from pip._internal.pyproject import load_pyproject_toml, make_pyproject_path
#15 0.442 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#15 0.442 File "/usr/local/lib/python3.11/site-packages/pip/_internal/pyproject.py", line 8, in <module>
#15 0.442 import tomllib
#15 0.442 ^^^^^^^^^^^^^^
#15 0.442 ModuleNotFoundError: No module named 'tomllib'
#15 ERROR: process "/bin/sh -c pip install --prefix /install --no-warn-script-location --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1
------
> [builder 5/5] RUN pip install --prefix /install --no-warn-script-location --no-cache-dir -r requirements.txt:
0.442 File "/usr/local/lib/python3.11/site-packages/pip/_internal/req/__init__.py", line 9, in <module>
0.442 from .req_install import InstallRequirement
0.442 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0.442 File "/usr/local/lib/python3.11/site-packages/pip/_internal/req/req_install.py", line 41, in <module>
0.442 from pip._internal.pyproject import load_pyproject_toml, make_pyproject_path
0.442 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0.442 File "/usr/local/lib/python3.11/site-packages/pip/_internal/pyproject.py", line 8, in <module>
0.442 import tomllib
0.442 ^^^^^^^^^^^^^^
0.442 ModuleNotFoundError: No module named 'tomllib'
------
Dockerfile:13
--------------------
11 |
12 | RUN pip install --upgrade pip
13 | >>> RUN pip install --prefix /install --no-warn-script-location --no-cache-dir -r requirements.txt
14 |
15 | FROM python:3.11.0a5-alpine
--------------------
ERROR: failed to solve: process "/bin/sh -c pip install --prefix /install --no-warn-script-location --no-cache-dir -r requirements.txt" did not complete successfully: exit code: 1
Error: Process completed with exit code 1. |
benbusby
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generated opensearch xml have a unwanted trailing
\n
in description, casued by the line break before</Description>
. This PR solves this and updates desc to latest one in GitHub repo. The latter is arguable but tbh the original one is so long that it can't be fully shown if added to browser search engine. A change is needed anyway.