Fix: added a functionality to make sure escaped characters stay escaped. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the cleaner functions to app/utils/escaper.py Fixes Removed unused import 're' Moved the cleaner functionalities to the "search.py" and "routes.py" Making sure escaped chars stay escaped during process Replaced "<" and ">" with "andlt;" and "andgt;", respectively. This way, when the 'response' object get loaded to bsoup (which happens several times throughout the process between search.py and routes.py), bsoup will not unescape them.
You're welcome! It's a pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to the issue #908 which shows that, basically, Whoogle results render html characters unescaped. Here's a screenshot as referenced in the issue:
After checking, I found out that several points:
<div>content tag from the search results (getbody.textin search.py) are already escaped, with"<"and">"characters converted into"<"and">", respectivelygetbody.textthen passed through severalbsoupclass, the escaped tag characters became unescaped.To prevent this, I replaced
"<"and">"with"andlt;"and"andgt;", respectively. This way, when the 'response' object get loaded tobsoup(which happens several times throughout the process between search.py and routes.py),bsoupwill not unescape them. Finally, at the end, before theresponsesobject sent to therender_templateinroutes.py, I simply replaced the"andlt;"and"andgt;"back to"<"and">".Here's the screenshot from the search result on Whoogle following this fix: