Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Reporting Websockets (also Count and Rate) #39

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

PatrickLevy
Copy link
Contributor

@PatrickLevy PatrickLevy commented Mar 4, 2022

Hello, thank you so much for making this k6 reporter! I needed it to be able to support websockets and I saw two issues:

  • An error would get thrown trying to process data.metrics.iterations.values.count because iterations doesn't exist for websockets
  • Most of the results wouldn't get displayed because most of them are "count" or "rate"
  • This pr also addresses this issue: Report do not include Count metrics #32

If you like this please merge. If you'd like to implement it differently please go ahead and just close the pr. Thanks again.

Here's a screenshot:
image

@PatrickLevy PatrickLevy changed the title Add Support for Reporting Websockets Add Support for Reporting Websockets (also Count and Rate) Mar 4, 2022
@benc-uk
Copy link
Owner

benc-uk commented Mar 5, 2022

Looks good, LGTM

@benc-uk benc-uk merged commit 66411b0 into benc-uk:main Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants