Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Loosen httpx dependency BNCH-38599 #115

Conversation

daniel-deutsch-benchling

httpx changelog: https://github.com/encode/httpx/blob/master/CHANGELOG.md

There are some breaking changes, like parameter names that removed in 0.18.0 and 0.20.0.
I looked through them and we should not be affected, and we should be able to be more confident after running our integration tests.

Given they do have breaking changes pre-1.0, I am continuing to declare an upper bound (<=0.22.0) as opposed to loosening even further.

@daniel-deutsch-benchling daniel-deutsch-benchling merged commit c197208 into benchling-sdk-m1-fixes-01282021 Apr 8, 2022
@eli-bl eli-bl deleted the ddeutsch-httpx-loosen-BNCH-38599 branch November 26, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant