feat: Added support for text/yaml in OpenAPI to be used in benchling-api-client BNCH-37249 #118
Conversation
…api-client BNCH-37249
There was a problem hiding this comment.
I think this looks pretty good but added @daniel-deutsch-benchling to help make sure I'm not missing anything.
I did find some issues in https://github.com/benchling/benchling-api-client/pull/21 with repeated types that may need to be addressed here.
| @@ -22,6 +22,7 @@ class Response: | |||
| "application/json": "response.json()", | |||
| "application/octet-stream": "response.content", | |||
| "text/html": "response.text", | |||
| "text/yaml": "yaml.safe_load(response.text.encode('utf-8'))", | |||
There was a problem hiding this comment.
That's a lot of logic to put in the value - is it possible to encapsulate most of that somewhere into a function that accepts response?
| "text/yaml": "yaml.safe_load(response.text.encode('utf-8'))", | |
| "text/yaml": "to_yaml(response)", |
There was a problem hiding this comment.
Broke this down on the latest commit
| @@ -22,6 +22,7 @@ class Response: | |||
| "application/json": "response.json()", | |||
| "application/octet-stream": "response.content", | |||
| "text/html": "response.text", | |||
| "text/yaml": "yaml.safe_load(response.text.encode('utf-8'))", | |||
There was a problem hiding this comment.
That's a lot of logic to put in the value - is it possible to encapsulate most of that somewhere into a function that accepts response?
| "text/yaml": "yaml.safe_load(response.text.encode('utf-8'))", | |
| "text/yaml": "to_yaml(response)", |
| @@ -1,6 +1,12 @@ | |||
| {% macro construct(property, source, initial_value=None) %} | |||
| {% if property.required and not property.nullable %} | |||
| {% if source == "response.yaml" %} | |||
| yaml = YAML(typ="base") | |||
There was a problem hiding this comment.
We were previously using the safe loaded from PyYaml. Does that not work here?
| yaml = YAML(typ="base") | |
| yaml = YAML(typ="safe") |
Added text/yaml support.
Fixed some unit tests and added 1 to check for text/yaml support