Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen algorithm has a bug when it descends into
UnionProperties
with an anonymousobject
as an inner type. Example:The codegen used to be forgiving because it would always return an instance of
FieldValueWithResolution(additional_properties=...)
without any attempt to get the nested structure correct.Now that we are generating typevars, the broken recursion is generating children with the same name
as the parent, which results in this output:
A correct fix would overhaul the recursive parser, much more than we can afford to do for now.
A reasonable quick fix is to add a filter on the
get_type_strings()
method to filter out children with the same name as the parent: