fix: Generate parameters to generated client without adding None BNCH-22940 #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
William was reviewing this set of changes on the benchling-sdk side for https://github.com/benchling/benchling-sdk/pull/149, but has indicated he's about to be OOO. |
forest-benchling
approved these changes
Jul 8, 2021
|
@forest-benchling yes, and so that we don't continue to accidentally try to call the client functions with None in the interim period before the switch. |
@GitOnUp 👍 . Just to clarify, that this is only a matter of type hinting--we're still allowing runtime calls with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream generates the client this way, and in a parallel benchling-sdk ticket we'll be doing a conversion to UNSET for None parameters in the service layer. Making this change in the fork in the meantime will keep us in a good state.