-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed parsing model names for OLED TVs later than 2019 #55
base: master
Are you sure you want to change the base?
Conversation
@bendavid Not sure why the checks keep failing. It looks like a GitHub/Azure issue, unrelated to the actual changes. |
@chros73 Any idea why these checks keep failing? |
Not sure why the pre-commit script failed, try to amend the commit and push it up again, maybe it was a glitch in Azure. But more importantly: have you tried out the calibration functionality with newer models? Which model do you have? There were reports that it doesn't work on C1, and allowing this blindly can even break TVs ... |
@chros73 The checks failed again. As for the other question: yes, I did use the script with my 48-inch C1. |
Hm, with the same error, I'm clueless.
Thanks, good to know! Not sure what was the issue with other users then. |
Yes, they most certainly did. It looks like a github vs azure configuration issue. |
OK, thanks for the code otherwise! @bendavid can still manually add this or fix the azure issue if he thinks it's safe to go. |
Thanks for the idea, I extended it in the new bscpylgtv v0.4.0, it's mostly about calibration changes, lot of new stuff has been added. |
Actually I just scrapped the whole logic based on model names, and I implemented another one based on chip types (and added more enhancements). |
This is a very simple fix, but necessary to be able to use 1D/3D LUT calibration on 2020–2021 OLED TVs. Should work for the next few years, as well.