Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing model names for OLED TVs later than 2019 #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

develancer
Copy link

This is a very simple fix, but necessary to be able to use 1D/3D LUT calibration on 2020–2021 OLED TVs. Should work for the next few years, as well.

@develancer
Copy link
Author

@bendavid Not sure why the checks keep failing. It looks like a GitHub/Azure issue, unrelated to the actual changes.

@develancer
Copy link
Author

@chros73 Any idea why these checks keep failing?

@chros73
Copy link

chros73 commented Apr 9, 2022

Not sure why the pre-commit script failed, try to amend the commit and push it up again, maybe it was a glitch in Azure.

But more importantly: have you tried out the calibration functionality with newer models? Which model do you have? There were reports that it doesn't work on C1, and allowing this blindly can even break TVs ...

@develancer
Copy link
Author

develancer commented Apr 12, 2022

@chros73 The checks failed again.

As for the other question: yes, I did use the script with my 48-inch C1.
DDC reset and 1-D LUT upload went smoothly. Haven’t tried all functions, though.

@chros73
Copy link

chros73 commented Apr 13, 2022

The checks failed again

Hm, with the same error, I'm clueless.
Do you have the hooks enabled locally? If so, did it pass locally?

yes, I did use the script with my 48-inch C1.
DDC reset and 1-D LUT upload went smoothly. Haven’t tried all functions, though.

Thanks, good to know! Not sure what was the issue with other users then.
I think something is changed in C1, there should be a complementary 1dlut as well, that can affect DDC reset. Also DoVi config could be changed (in CX/C1/C2) and that is the scary one :)

@develancer
Copy link
Author

Hm, with the same error, I'm clueless. Do you have the hooks enabled locally? If so, did it pass locally?

Yes, they most certainly did. It looks like a github vs azure configuration issue.
Only the administrator of this repo may be able to fix it.

@chros73
Copy link

chros73 commented Apr 13, 2022

OK, thanks for the code otherwise! @bendavid can still manually add this or fix the azure issue if he thinks it's safe to go.
Nevertheless, I'll probably get a 2022 model soon(ish), so I can also try out the calibration functionalities. So let's keep in contact :)

@chros73
Copy link

chros73 commented Oct 23, 2022

Thanks for the idea, I extended it in the new bscpylgtv v0.4.0, it's mostly about calibration changes, lot of new stuff has been added.
Enjoy!

@chros73
Copy link

chros73 commented Oct 29, 2022

Actually I just scrapped the whole logic based on model names, and I implemented another one based on chip types (and added more enhancements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants