cylc#1872: comms layer to https

bin/cylc-broadcast

@@ -71,7 +71,7 @@ import cylc.flags
 from cylc.broadcast_report import (
     get_broadcast_change_report, get_broadcast_bad_options_report)
 from cylc.CylcOptionParsers import cop
-from cylc.network.suite_broadcast import BroadcastClient
+from cylc.network.suite_broadcast_client import BroadcastClient
 from cylc.print_tree import print_tree
 from cylc.task_id import TaskID
 from cylc.cfgspec.suite import SPEC, upg
@@ -202,7 +202,7 @@ def main():
                 name, point_string = TaskID.split(options.showtask)
             except ValueError:
                 parser.error("TASKID must be " + TaskID.SYNTAX)
-        settings = pclient.broadcast('get', options.showtask)
+        settings = pclient.broadcast('get', task_id=options.showtask)
         padding = get_padding(settings) * ' '
         if options.raw:
             print str(settings)
@@ -212,15 +212,17 @@ def main():
 
     if options.clear:
         modified_settings, bad_options = pclient.broadcast(
-            'clear', options.point_strings, options.namespaces)
+            'clear', point_strings=options.point_strings,
+            namespaces=options.namespaces
+        )
         if modified_settings:
             print get_broadcast_change_report(
                 modified_settings, is_cancel=True)
         sys.exit(get_broadcast_bad_options_report(bad_options))
 
     if options.expire:
         modified_settings, bad_options = pclient.broadcast(
-            'expire', options.expire)
+            'expire', cutoff=options.expire)
         if modified_settings:
             print get_broadcast_change_report(
                 modified_settings, is_cancel=True)
@@ -249,7 +251,9 @@ def main():
             validate(setting, SPEC['runtime']['__MANY__'])
             settings.append(setting)
         modified_settings, bad_options = pclient.broadcast(
-            'clear', point_strings, namespaces, settings)
+            'clear', point_strings=point_strings,
+            namespaces=namespaces, cancel_settings=settings
+        )
         if modified_settings:
             print get_broadcast_change_report(
                 modified_settings, is_cancel=True)
@@ -270,7 +274,9 @@ def main():
             validate(setting, SPEC['runtime']['__MANY__'])
             settings.append(setting)
         modified_settings, bad_options = pclient.broadcast(
-            'put', point_strings, namespaces, settings)
+            'put', point_strings=point_strings,
+            namespaces=namespaces, settings=settings
+        )
         print get_broadcast_change_report(modified_settings)
         sys.exit(get_broadcast_bad_options_report(bad_options, is_set=True))
 

bin/cylc-dump

@@ -40,7 +40,7 @@ if '--use-ssh' in sys.argv[1:]:
         sys.exit(0)
 
 import cylc.flags
-from cylc.network.suite_state import StateSummaryClient
+from cylc.network.suite_state_client import StateSummaryClient
 from cylc.CylcOptionParsers import cop
 from cylc.dump import dump_to_stdout
 

bin/cylc-ext-trigger

@@ -40,7 +40,7 @@ import sys
 
 import cylc.flags
 from cylc.CylcOptionParsers import cop
-from cylc.network.ext_trigger import ExtTriggerClient
+from cylc.network.ext_trigger_client import ExtTriggerClient
 
 
 def main():

bin/cylc-get-suite-version

@@ -32,7 +32,7 @@ if '--use-ssh' in sys.argv[1:]:
 import cylc.flags
 from cylc.CylcOptionParsers import cop
 from cylc.task_id import TaskID
-from cylc.network.suite_info import SuiteInfoClient
+from cylc.network.suite_info_client import SuiteInfoClient
 from cylc.cfgspec.globalcfg import GLOBAL_CFG
 
 

bin/cylc-hold

@@ -35,7 +35,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 
@@ -66,11 +66,13 @@ def main():
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
     if args:
-        items, compat = parser.parse_multitask_compat(options, args)
-        pclient.put_command('hold_task', items, compat)
+        items = parser.parse_multitask_compat(options, args)
+        pclient.put_command('hold_tasks', items=items)
     elif options.hold_point_string:
         pclient.put_command(
-            'hold_after_point_string', options.hold_point_string)
+            'hold_after_point_string',
+            point_string=options.hold_point_string
+        )
     else:
         pclient.put_command('hold_suite')
 

bin/cylc-insert

@@ -42,7 +42,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 from cylc.task_id import TaskID
 
@@ -68,14 +68,13 @@ def main():
     if (options.multitask_compat and len(args) in [2, 3] and
             all(["/" not in arg for arg in args]) and
             all(["." not in arg for arg in args[1:]])):
-        items, compat = (args[0], args[1])
+        items = [(args[0] + "." + args[1])]
         if len(args) == 3:
             options.stop_point_string = args[2]
         prompt(
-            'Insert %s at %s in %s' % (items, compat, suite),
-            options.force)
+            'Insert %s in %s' % (items, suite), options.force)
     else:
-        items, compat = (args, None)
+        items = args
         for i, item in enumerate(items):
             if not TaskID.is_valid_id_for_insert(item):
                 sys.exit('ERROR: "%s": invalid task ID (argument %d)' % (
@@ -88,7 +87,9 @@ def main():
         print_uuid=options.print_uuid)
 
     pclient.put_command(
-        'insert_task', items, compat, None, options.stop_point_string)
+        'insert_tasks', items=items,
+        stop_point_string=options.stop_point_string
+    )
 
 
 if __name__ == "__main__":

bin/cylc-kill

@@ -33,7 +33,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 
@@ -55,8 +55,8 @@ def main():
         suite, options.owner, options.host, options.pyro_timeout,
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
-    items, compat = parser.parse_multitask_compat(options, args)
-    pclient.put_command('kill_tasks', items, compat)
+    items = parser.parse_multitask_compat(options, args)
+    pclient.put_command('kill_tasks', items=items)
 
 
 if __name__ == "__main__":

bin/cylc-monitor

@@ -33,7 +33,7 @@ from time import sleep
 
 from parsec.OrderedDict import OrderedDict
 from cylc.CylcOptionParsers import cop
-from cylc.network.suite_state import (
+from cylc.network.suite_state_client import (
     SUITE_STATUS_SPLIT_REC, get_suite_status_string, StateSummaryClient,
     SuiteStillInitialisingError)
 from cylc.wallclock import get_time_string_from_unix_time

bin/cylc-nudge

@@ -37,7 +37,7 @@ if '--use-ssh' in sys.argv[1:]:
         sys.exit(0)
 
 import cylc.flags
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 

bin/cylc-ping

@@ -31,7 +31,7 @@ if '--use-ssh' in sys.argv[1:]:
 import cylc.flags
 from cylc.CylcOptionParsers import cop
 from cylc.task_id import TaskID
-from cylc.network.suite_info import SuiteInfoClient
+from cylc.network.suite_info_client import SuiteInfoClientAnon
 from cylc.cfgspec.globalcfg import GLOBAL_CFG
 
 
@@ -55,11 +55,10 @@ def main():
 
     suite = args[0]
 
-    pclient = SuiteInfoClient(
+    pclient = SuiteInfoClientAnon(
         suite, options.owner, options.host, options.pyro_timeout,
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
-    pclient.set_use_scan_hash()
 
     # cylc ping SUITE
     pclient.get_info('ping_suite')  # (no need to check the result)
@@ -72,7 +71,7 @@ def main():
     task_id = args[1]
     if not TaskID.is_valid_id(task_id):
         sys.exit("Invalid task ID: " + task_id)
-    success, msg = pclient.get_info('ping_task', task_id)
+    success, msg = pclient.get_info('ping_task', task_id=task_id)
     if not success:
         sys.exit('ERROR: ' + msg)
 

bin/cylc-poll

@@ -40,7 +40,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 
@@ -62,8 +62,8 @@ def main():
         suite, options.owner, options.host, options.pyro_timeout,
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
-    items, compat = parser.parse_multitask_compat(options, args)
-    pclient.put_command('poll_tasks', items, compat)
+    items = parser.parse_multitask_compat(options, args)
+    pclient.put_command('poll_tasks', items=items)
 
 
 if __name__ == "__main__":

bin/cylc-release

@@ -34,7 +34,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 
@@ -57,8 +57,8 @@ def main():
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
     if args:
-        items, compat = parser.parse_multitask_compat(options, args)
-        pclient.put_command('release_task', items, compat)
+        items = parser.parse_multitask_compat(options, args)
+        pclient.put_command('release_tasks', items=items)
     else:
         pclient.put_command('release_suite')
 

bin/cylc-reload

@@ -47,7 +47,7 @@ if '--use-ssh' in sys.argv[1:]:
         sys.exit(0)
 
 import cylc.flags
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 from cylc.prompt import prompt
 

bin/cylc-remove

@@ -33,7 +33,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 
@@ -57,10 +57,9 @@ def main():
         suite, options.owner, options.host, options.pyro_timeout,
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
-    items, compat = parser.parse_multitask_compat(options, args)
-    pclient.put_command('remove_task', items, compat,
-                        None, not options.no_spawn)
-
+    items = parser.parse_multitask_compat(options, args)
+    pclient.put_command('remove_tasks', items=items,
+                        spawn=(not options.no_spawn))
 
 if __name__ == "__main__":
     try:

bin/cylc-reset

@@ -38,7 +38,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 from cylc.task_state import TASK_STATUSES_CAN_RESET_TO
 
@@ -80,8 +80,9 @@ def main():
         suite, options.owner, options.host, options.pyro_timeout,
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
-    items, compat = parser.parse_multitask_compat(options, args)
-    pclient.put_command('reset_task_state', items, compat, options.state)
+    items = parser.parse_multitask_compat(options, args)
+    pclient.put_command(
+        'reset_task_states', items=items, state=options.state)
 
 
 if __name__ == "__main__":

bin/cylc-set-runahead

@@ -34,7 +34,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 
@@ -59,7 +59,7 @@ def main():
     if runahead:
         prompt('Change runahead limit in %s to %s' % (suite, runahead),
                options.force)
-        pclient.put_command('set_runahead', runahead)
+        pclient.put_command('set_runahead', interval=runahead)
     else:
         # no limit!
         prompt('Change runahead limit in %s to NO LIMIT' % suite,

bin/cylc-set-verbosity

@@ -33,7 +33,7 @@ if '--use-ssh' in sys.argv[1:]:
 
 import cylc.flags
 from cylc.prompt import prompt
-from cylc.network.suite_command import SuiteCommandClient
+from cylc.network.suite_command_client import SuiteCommandClient
 from cylc.CylcOptionParsers import cop
 
 LOGGING_LVL_OF = {
@@ -70,7 +70,7 @@ def main():
         options.port, options.db, my_uuid=options.set_uuid,
         print_uuid=options.print_uuid)
 
-    pclient.put_command('set_verbosity', priority)
+    pclient.put_command('set_verbosity', level=priority)
 
 
 if __name__ == "__main__":

bin/cylc-show

@@ -30,7 +30,8 @@ if '--use-ssh' in sys.argv[1:]:
         sys.exit(0)
 
 import cylc.flags
-from cylc.network.suite_info import SuiteInfoClient
+from cylc.network.suite_info_client import (
+    SuiteInfoClient, SuiteInfoClientAnon)
 from cylc.CylcOptionParsers import cop
 from cylc.task_id import TaskID
 
@@ -47,7 +48,8 @@ def main():
     pclient = SuiteInfoClient(
         suite, options.owner, options.host, options.pyro_timeout,
         options.port, options.db, my_uuid=options.set_uuid,
-        print_uuid=options.print_uuid)
+        print_uuid=options.print_uuid
+    )
 
     if len(args) == 1:
         # Print suite info.
@@ -67,14 +69,16 @@ def main():
         # Print task instance info.
         task_id = arg
 
-    info = pclient.get_info('get_task_info', name)
+    info = pclient.get_info('get_task_info', name=name)
     if not info:
         sys.exit("ERROR: task not found: %s" % name)
     for key, value in sorted(info.items(), reverse=True):
         print "%s: %s" % (key, value or "(not given)")
 
     if point_string is not None:
-        result = pclient.get_info('get_task_requisites', name, point_string)
+        result = pclient.get_info('get_task_requisites',
+                                  name=name,
+                                  point_string=point_string)
         if not result:
             sys.exit("ERROR: task instance not found: %s" % task_id)