Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to install implicit without GPU support #446

Closed
epetrovski opened this issue Mar 5, 2021 · 2 comments · Fixed by #561
Closed

Option to install implicit without GPU support #446

epetrovski opened this issue Mar 5, 2021 · 2 comments · Fixed by #561

Comments

@epetrovski
Copy link

It would be great if there was an option to install implicit without GPU support.

I'm currently not able to install implicit seemingly because running pip install implicit detects CUDA but then install fails with /usr/bin/ld: cannot find -lcublas.
@epetrovski
Copy link
Author

I was able to fix my lcublas issue. But still, it would be nice if the user could opt out of GPU support at install time.

benfred added a commit that referenced this issue Apr 11, 2022
@benfred
Disable building GPU extension if IMPLICIT_DISABLE_CUDA environment v…
88bb71e 
…ariable is set

Add an option to build implicit without the GPU extension, if the IMPLICIT_DISABLE_CUDA
is set. Closes #446
@benfred benfred mentioned this issue Apr 11, 2022
Merged
@benfred
Copy link
Owner

benfred commented Apr 11, 2022

@epetrovski - I've added some code in #561 to allow building implicit with the GPU extension. You can go export IMPLICIT_DISABLE_CUDA=1 and then the GPU extension won't get built.

However, we have prebuilt binary wheels on pypi now - and going pip install implicit will install both the CPU and GPU code on linux. If you don't have a GPU/cuda/cublas the GPU extension will be automatically disabled though, so this shouldn't be a big deal.

benfred added a commit that referenced this issue Apr 11, 2022
@benfred
Disable building GPU extension if IMPLICIT_DISABLE_CUDA env var is set (
7171765 
#561)

Disable building GPU extension if IMPLICIT_DISABLE_CUDA environment variable is set

Add an option to build implicit without the GPU extension, if the IMPLICIT_DISABLE_CUDA
is set. Closes #446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable building GPU extension if IMPLICIT_DISABLE_CUDA env var is set benfred/implicit
2 participants
@benfred @epetrovski