check user and item matrix for nan entries also in bpr gpu version #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are model parameters where the matrix factorization of
BayesianPersonalizedRanking
fails.In this case some (or all) entries of the user and the item matrix become NaN.
While this applies to both the CPU and the GPU version, the CPU version already features a corresponding check. In this pull request I added a similar check to the GPU version and consolidated the source code.
Side Note: Not having this check can be quite misleading. Because in this case a strange behavior can be observed:
no error occurs but
recommend
returns items the user already liked even withfilter_already_liked_items
set toTrue
. It can be verified using the following test: