Warn about SYS_PTRACE when running in docker #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we get a permissions denied error when running in docker, ask about the SYS_PTRACE capabality. Also only ask to run as sudo when we're not running as root already.
Jongy
reviewed
Oct 22, 2021
| // Otherwise, fall through to the generic error handling | ||
| #[cfg(target_os="linux")] | ||
| if let Ok(cgroups) = std::fs::read_to_string("/proc/self/cgroup") { | ||
| if cgroups.contains("/docker/") { |
There was a problem hiding this comment.
This works in Docker but not in all containerized environments. I think it's better to test for the SYS_PTRACE capability itself here?
There was a problem hiding this comment.
Thats a good point! We could test for the SYS_PTRACE cap directly using capget - or maybe using a crate like https://github.com/lucab/caps-rs
There was a problem hiding this comment.
Yeah I was thinking about caps-rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get a permissions denied error when running in docker, ask about the
SYS_PTRACE capabality. Also only ask to run as sudo when we're not running
as root already.
This will output
when running in docker as root, rather than
Permission Denied: Try running again with elevated permissions by going 'sudo env "PATH=$PATH" !!'