Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chrome trace format for recording samples #627

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

andrewjcg
Copy link
Contributor

This adds "chrometrace" as a new format for the "record" command, which serializes samples using chrome trace events: https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU

Copy link
Owner

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! overall it looks good - have some minor comments below

src/chrometrace.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/chrometrace.rs Outdated Show resolved Hide resolved
This adds "chrometrace" as a new format for the "record" command,
which serializes samples using chrome trace events:
https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU
@benfred benfred merged commit cbcfdf0 into benfred:master Nov 10, 2023
182 checks passed
@benfred benfred added the enhancement New feature or request label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants