Use new musl cross build Docker images #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/upgrade-musl
branch
from
9638ae0
to
596a03c
Compare
zanieb
force-pushed
the
zb/upgrade-musl
branch
from
596a03c
to
ad72ae7
Compare
zanieb
commented
Oct 16, 2024
Comment on lines
-92
to
+97
| target: [i686-musl, armv7-musleabihf, aarch64-musl, x86_64-musl] | ||
| target: | ||
| [ | ||
| i686-unknown-linux-musl, | ||
| armv7-unknown-linux-musleabihf, | ||
| aarch64-unknown-linux-musl, | ||
| x86_64-unknown-linux-musl, |
There was a problem hiding this comment.
When published upstream, these tags are shortened. I didn't bother with that in the fork.
zanieb
commented
Oct 16, 2024
Comment on lines
-104
to
+110
| maturin build --release -o dist --target $RUST_MUSL_CROSS_TARGET --features unwind | ||
| maturin build --release -o dist --target ${{ matrix.target }} --features unwind |
There was a problem hiding this comment.
Now that the tag matches the target, we can just use it directly which is a little clearer for someone not familiar with the container environment.
benfred
approved these changes
Oct 16, 2024
benfred
added a commit
to benfred/remoteprocess
that referenced
this pull request
Oct 28, 2024
Similar to benfred/py-spy#702, this upgrades GHA to use newer docker images for CI.
benfred
added a commit
to benfred/remoteprocess
that referenced
this pull request
Oct 28, 2024
Similar to benfred/py-spy#702, this upgrades GHA to use newer docker images for CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From benfred/rust-musl-cross#2
Will unblock various dependency upgrades since we won't be stuck on an old toolchain version.