Add option to output intermediate stacks #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than shorten python filenames by removing the python install prefix, only include directories that are python packages or subpackages
This was referenced Jan 28, 2019
|
I really need this feature to integrate with other visualizers like speedscope. |
Closed
Closed
|
Will this be merged at any point? |
|
@benfred any reason this PR not to be merged? |
|
Thanks for the PR ! Sorry about the delay on getting back to you on this - I wasn't sure about customizing the flamegraph code more since it was taken from rbspy, and there was some potential licensing headaches w/ py-spy being GPL and rbspy being MIT (like I wanted to merge this code and some others into a common library and would be complicated to do that with changes from other people in the py-spy variant). I've relicensed this entire project to MIT so get around this with 0.2.0 - and I've also added this functionality there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38
#45