Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97
Add support, without changing the default behaviour, to apply the width and height to the SVG via the
viewBox
attribute rather thanwidth
andheight
attributes. This is preferable when incorporating into responsive layouts, as it specifies the width and height merely as an aspect ratio and lets the SVG grow or shrink to any size depending on its containing element (and/or any CSS applied).To use, you just call
useViewBox
on the createdVennDiagram
- it's a one-way setting:I added an alternate version of the "simple" example which uses this, and added screenshot tests for both with BackstopJS (sorry about all the boilerplate files!) which show the difference - you can run
npm run backstop-check
to see them.